For Antonio (some required changes)

[byte-one]

Antonio, the following points are to review and solve:

*********************************************************
If empty cells to export to Excel or fields with CRLF in Text (memo), this changes are required.

Code: Select all  Expand view

METHOD ClpRow( lFullRow ) CLASS TXBrowse

   local nLast := Len( ::aCols )
   local n, RetVal := ""

   DEFAULT lFullRow := ( ::nMarqueeStyle >= 4 )

   if lFullRow
      for n := 1 to nLast
         if ! ::aCols[ n ]:lHide
*            if ! Empty( RetVal )
*               RetVal   += Chr( 9 )
*            endif
            RetVal += strtran(::aCols[ n ]:ClpText,CRLF," ; ") + Chr( 9 ) //changed byte-one
         endif
      next
   else
      RetVal   := strtran(::SelectedCol():ClpText,CRLF," ; ")
   endif

return RetVal

*********************************************************
CLASS TFolder FROM TControl
.
METHOD SetPrompts( aPrompts , aHelps ) //add ", aHelps"
.
ENDCLASS
**********************************************************
TButton
METHOD New()
nHelpId := 100 //should NOT! be defined
**********************************************************
TControl
DATA nHelpPosX //both datas are to erase! (is from an older code for HTML-Help)
DATA nHelpPosY
********************************************************
TPrinter
METHOD Say()

ExtTextOut( ::hDCOut, nRow, nTemp,;
{ nRow, nCol, nRow+oFont:nHeight*1.5, nCol+nWidth },; //add "*1.5" to show also the part of the letter under the groundline z.B. "g"
cText, ETO_CLIPPED )
*********************************************************
TWindow
METHOD __HelpTopic() CLASS TWindow
if ::oWnd != nil ;
.and. Upper( ::oWnd:ClassName() ) != "TFOLDER" ;
.and. Upper( ::oWnd:ClassName() ) != "TPAGES" ;
.and. Upper( ::oWnd:ClassName() ) != "TDIALOG" ;
.and. Upper( ::oWnd:ClassName() ) != "TWINDOW" //add also this for Help-system
***********************************************************

[byte-one]

Antonio, have you seen this points? For next release please check this.

[Antonio Linares]

Günther,

We have added all your suggested changes, thanks

Except this one:
CLASS TPrinter METHOD Say(), 1.5 modification as we think that we could break existing working applications. Not sure about it. Feedback is welcome.

Also, in:
.and. Upper( ::oWnd:ClassName() ) != "TWINDOW"
shouldn't we also add TMDIFRAME and TMDICHILD ?

[byte-one]

Antonio, the multiplicator from 1.5 i use many years ago. No sideeffects are seen! Its only increase the high of the paint-window from the text. oFont:nHight is only from the groundline from the last textline to the groundline from the actual line. And then are cutted the "g" etc.
Maybee this are an help (in German): http://msdn.microsoft.com/de-de/library/xwf9s90b.aspx

The other point I will test. Or are all this lines to to erase. I will tell you.

Another bug? i seen is the font from folders:

DEFINE WINDOW oWnd.....
oWnd:setfont(oFont)
REDEFINE DIALOG oDlg OF oWnd ....
REDEFINE FOLDER OF oDlg ......
The font from the dialog is the same of the window, but the font of the folder dialogs are standard. When i use REDEFINE DIALOG oDlg FONT oFont)... , then it is functioning.

[Antonio Linares]

Günther,

> the multiplicator from 1.5 i use many years ago. No sideeffects are seen!

Ok, we have included it for next FWH 9.01 build. Thanks

Please start a new thread to discuss that reported bug, thanks

[byte-one]

Antonio, the following change from xbrowse as above is not included in 9.01!?

If empty cells to export to Excel or fields with CRLF in Text (memo), this changes are required.

[Antonio Linares]

Günther,

We missed it, sorry.

We are going to include it and publish it again today.

[byte-one]

Thanks Antonio, FIVEWIN is a "Great Thing"!!

[Antonio Linares]

Günther,

Already uploaded FWH 9.01 again with such change,

We are a great community of friends