Radio and GTF problem

[byte-one]

It seems, that the codeblock ::bchange on radios evaluated twice when changing the radiooption!
Please try oRadio:bchange := {||msginfo("Changed")}

In the meanwhile i found, that this only appears, if in the function of the codeblock a call to another dialog are present. (msginfo(),..).
A bPainted-call of the parent-window??

I have removed Eval( ::bChange, Self ) in method refresh() from TRadmenu-class. But this is only a hack.
Antonio?


Another problem with GTF!
Without commenting out the 2 lines in the following code-snippet from METHOD SetFormat( oFont, nColor ) CLASS TFGet the current font are destroyed!

Code: Select all  Expand view

     if lIsFont
//         DeleteObject( oFont:hFont )
//         oFont:hFont := oOldFont:hFont
         ::hFont := oOldFont:hFont
      else
         AAdd( ::aFonts, oFont )
         ::hFont := oFont:hFont
      endif

[byte-one]

Antonio, please take a look at this!

[Antonio Linares]

Günther,

Thanks for the reminder, as I missed this post from you

> In the meanwhile i found, that this only appears, if in the function of the codeblock a call to another dialog are present. (msginfo(),..).
A bPainted-call of the parent-window??

Surely it is related to the focus. Those functions change the focus

Could you provide a small and self contained example PRG to reproduce it ? many thanks

[Antonio Linares]

I have modified samples\testrad.prg with this:

REDEFINE RADIO oRadMenu VAR nOption ID 110, 120, 130, 140, 150 OF oDlg ;
ON CHANGE MsgInfo( nOption )

and it only appears once

[byte-one]

Antonio, i have made inside my program a simple dialog with only a radio with 5 items and a button. ON CHANGE of the radio call a msginfo(). This msginfo are showing a second one if i close the first one!
WIN 10??

[nageswaragunupudi]

Antonio, i have made inside my program a simple dialog with only a radio with 5 items and a button. ON CHANGE of the radio call a msginfo(). This msginfo are showing a second one if i close the first one!
WIN 10??

Can you provide a sample please?

[byte-one]

Antonio, Mr Nages, there are a test!
The problem is only present if the dialog is child! The main window calls the refresh() and in this refresh() is bChange calling. Maybe other controls also affected!

Code: Select all  Expand view

function Main()
    local oWin

    DEFINE WINDOW oWin TITLE "Testrad"
    ACTIVATE WINDOW oWin ON INIT rad(oWin)

return NIL

function rad(oWin)
   local oDlg, oRadMenu, oBrush
   local nOption := 2

   DEFINE DIALOG oDlg RESOURCE "Radios" OF oWin

   REDEFINE RADIO oRadMenu VAR nOption ID 110, 120, 130, 140, 150 OF oDlg ;
      ON CHANGE Msginfo("Testrad")

   REDEFINE BUTTON ID 100 OF oDlg ACTION oRadMenu:GoNext() ;
      WHEN nOption == 3

   REDEFINE BUTTON ID 102 OF oDlg ACTION oRadMenu:GoPrev()

   ACTIVATE DIALOG oDlg ;
      ON INIT oRadMenu:aItems[ 1 ]:SetText( "Hello" )

return nil

[Antonio Linares]

Günther,

Please make this change in Class TRadio:

METHOD Click() INLINE ::oRadMenu:Select( Self ), ::Super:Click() // ::oRadMenu:Refresh()

that seems to solve it

Many thanks for the example

[byte-one]

Antonio, not the right way! The double call is take away but some radio-buttons stay checked if gonext() and goprev() and click on a radio-button with mouse!

[Antonio Linares]

How to reproduce it ?

Please provide instructions or a video, many thanks

[byte-one]

Please change the example to this one and click on next/prev. You see, no reaction from the radio-Buttons. In some cases more then one button is checked if i click with the mouse.

Code: Select all  Expand view

function Main()
    local oWin

    DEFINE WINDOW oWin TITLE "Testrad"
    ACTIVATE WINDOW oWin ON INIT rad(oWin)

return NIL

function rad(oWin)
   local oDlg, oRadMenu, oBrush
   local nOption := 2

   DEFINE DIALOG oDlg RESOURCE "Radios" OF oWin

   REDEFINE RADIO oRadMenu VAR nOption ID 110, 120, 130, 140, 150 OF oDlg ON CHANGE Msginfo(Eval( oRadmenu:bSetGet ))

   REDEFINE BUTTON ID 100 OF oDlg ACTION oRadMenu:GoNext()

   REDEFINE BUTTON ID 102 OF oDlg ACTION oRadMenu:GoPrev()

   ACTIVATE DIALOG oDlg

return nil

[Antonio Linares]

This method has to be modified this way:

Code: Select all  Expand view

METHOD Refresh() CLASS TRadMenu

   local nOption := Eval( ::bSetGet )
   local nAt     := AScan( ::aItems, { | oRadio | If( oRadio != nil, oRadio:lIsChecked(), .f. ) } )

   DEFAULT nOption := 1

   if nAt != nOption .and. nAt <= Len( ::aItems ) .and. Len( ::aItems ) > 0
      if nAt != 0
         ::aItems[ nAt ]:SetCheck( .f. )
      endif
      if ::aItems[ nOption ] != nil
         ::aItems[ nOption ]:SetCheck( .t. )
      endif
      // if ::bChange != nil                 no needed
      //    Eval( ::bChange, Self )
      // endif
   endif

return nil
 

[byte-one]

Antonio, thanks! To run next/prev, this change is required! Tested with my last sample.

Code: Select all  Expand view

METHOD GoPrevNext( lNext ) CLASS TRadMenu

   local nMove:= 0
   local nOption:= ::nOption

   DEFAULT lNext:= .F.

   while ! ( nMove > Len( ::aItems ) )
      nMove++

      if lNext
         nOption++
         nOption = If( nOption > Len(::aItems), 1, nOption )
      else
         nOption--
         nOption = If( nOption < 1, Len(::aItems), nOption )
      endif

      if ::aItems[ nOption ]:lWhen()
         ::nOption = nOption
     ::refresh(  )       //NEW
         exit
      endif

   enddo

//   if nOption != ::nOption
     //::SetOption( nOption )
//   endif

return Self