New FWH 18.01

[Antonio Linares]

viewtopic.php?f=16&t=35267&start=0

[Antonio Linares]

No os perdais los nuevos botones estilo Windows 10

viewtopic.php?f=3&t=35263

[ukoenig]

Antonio,

running the new release with different samples
I noticed some image-problems



the xbrowse-sample doesn't work anymore

missing alphablended

@ 518, 865 BITMAP oLogo[1] FILE c_path1 + "U-Kingdom.bmp" PIXEL NOBORDER OF oDlg
@ 554, 865 BITMAP oLogo[2] FILE c_path1 + "Spain.bmp" PIXEL NOBORDER OF oDlg
@ 589, 865 BITMAP oLogo[3] FILE c_path1 + "Italy.bmp" PIXEL NOBORDER OF oDlg
@ 625, 865 BITMAP oLogo[4] FILE c_path1 + "Germany.bmp" PIXEL NOBORDER OF oDlg
@ 660, 865 BITMAP oLogo[5] FILE c_path1 + "Portugal.bmp" PIXEL NOBORDER OF oDlg

FOR n := 1 to 5
aBitmap := oCol:aBitmap( If( n > nRating, 1, 2 ) )
oCol:oBrw:SayPalBmp( aBitmap, aBmpRect ) line 651
aBmpRect[ 2 ] += 20
aBmpRect[ 4 ] += 20
NEXT

Code: Select all  Expand view  RUN

Application
===========
   Path and name: I:\__F_SAMPLES\SAMPLES.exe (32 bits)
   Size: 4,070,912 bytes
   Compiler version: xHarbour 1.2.3 Intl. (SimpLex) (Build 20170902)
   FiveWin  version: FWHX 18.01
   C compiler version: Borland/Embarcadero C++ 7.3 (32-bit)
   Windows version: 6.2, Build 9200

   Time from start: 0 hours 0 mins 6 secs
   Error occurred at: 14/02/2018, 19:48:02
   Error description: Error BASE/1004  Message not found: TXBROWSE:SAYPALBMP

Stack Calls
===========
   Called from: .\source\function\HARBOUR.PRG => _CLSSETERROR( 247 )
   Called from: .\source\classes\XBROWSE.PRG => TXBROWSE:SAYPALBMP( 10146 )
   Called from: .\CODE_1.PRG => SHOWRATING( 651 )
   Called from: .\CODE_1.PRG => (b)GRPC1_SEC2( 561 )
   Called from: .\source\classes\XBROWSE.PRG => TXBRWCOLUMN:PAINTCELL( 12843 )
   Called from: .\source\classes\XBROWSE.PRG => TXBRWCOLUMN:PAINTDATA( 12504 )
   Called from: .\source\classes\XBROWSE.PRG => TXBROWSE:PAINT( 2028 )
   Called from: .\source\classes\XBROWSE.PRG => TXBROWSE:DISPLAY( 1753 )
   Called from: .\source\classes\CONTROL.PRG => TCONTROL:HANDLEEVENT( 1697 )
   Called from: .\source\classes\XBROWSE.PRG => TXBROWSE:HANDLEEVENT( 10442 )
   Called from: .\source\classes\WINDOW.PRG => _FWH( 3368 )
   Called from:  => DIALOGBOXINDIRECT( 0 )
   Called from: .\source\classes\DIALOG.PRG => TDIALOG:ACTIVATE( 296 )
   Called from: .\source\function\ERRSYSW.PRG => ERRORDIALOG( 436 )
   Called from: .\source\function\ERRSYSW.PRG => (b)ERRORSYS( 23 )
   Called from: .\source\function\HARBOUR.PRG => _CLSSETERROR( 247 )
   Called from: .\source\classes\XBROWSE.PRG => TXBROWSE:SAYPALBMP( 10146 )
   Called from: .\CODE_1.PRG => SHOWRATING( 651 )
   Called from: .\CODE_1.PRG => (b)GRPC1_SEC2( 561 )
   Called from: .\source\classes\XBROWSE.PRG => TXBRWCOLUMN:PAINTCELL( 12843 )
   Called from: .\source\classes\XBROWSE.PRG => TXBRWCOLUMN:PAINTDATA( 12504 )
   Called from: .\source\classes\XBROWSE.PRG => TXBROWSE:PAINT( 2028 )
   Called from: .\source\classes\XBROWSE.PRG => TXBROWSE:DISPLAY( 1753 )
   Called from: .\source\classes\CONTROL.PRG => TCONTROL:HANDLEEVENT( 1697 )
   Called from: .\source\classes\XBROWSE.PRG => TXBROWSE:HANDLEEVENT( 10442 )
   Called from: .\source\classes\WINDOW.PRG => _FWH( 3368 )
   Called from:  => DIALOGBOXINDIRECT( 0 )
   Called from: .\source\classes\DIALOG.PRG => TDIALOG:ACTIVATE( 296 )
   Called from: .\CODE_1.PRG => DO_CODE( 139 )
   Called from: .\SAMPLES.PRG => (b)MAIN( 282 )
 

regards
Uwe

[nageswaragunupudi]

Please replace
:SayPalBmp(..)
with

Code: Select all  Expand view  RUN

:DrawImage(..)
 

[ukoenig]

Thank You very much
it works

I had to add for all images

@ 518, 845 BITMAP oLogo[1] FILE c_path1 + "U-Kingdom.bmp" PIXEL NOBORDER OF oDlg
oLogo[1]:lTransparent = .t.

I think the release 17.12 has detected the alpachannel
and oLogo[1]:lTransparent = .t. was not needed

regards
Uwe

[nageswaragunupudi]

I think the release 17.12 detected the alpha channel

Mr Uwe

Upgrading FWH should not require you to change your source code.
In this case, it is our oversight.
Please make this correction in bitmap.prg

Line 733

Code: Select all  Expand view  RUN

     FW_DrawImage( Self, { ::hBitmap, ::hPalette, ::nImgWidth, ::nImgHeight }, aRect, ::lTransparent, 1, ::nAlphaLevel )
 

Please change it as:

Code: Select all  Expand view  RUN

     FW_DrawImage( Self, { ::hBitmap, ::hPalette, ::nImgWidth, ::nImgHeight }, aRect, ::lHasAlpha .or. ::lTransparent, 1, ::nAlphaLevel )
 

With this change you do not need to change your programs. Can you please check and confirm?

[ukoenig]

Mr. Rao,

Yes
In 17.12 I just needed to define the image.
I will test it in some samples changing between 17.12 and 18.1

regards
Uwe

[nageswaragunupudi]

Mr. Rao,

Yes
In 17.12 I just needed to define the image.
I will test it in some samples changing between 17.12 and 18.1

regards
Uwe

Please apply the fix to bitmap.prg and provide your feedback please.

[ukoenig]

One more test
the original sample < bmptext.prg > I only changed the image

from
@ 1, 1 BITMAP oBmp FILENAME "..\bitmaps\fw.bmp" OF oWnd
to
@ 1, 1 BITMAP oBmp FILENAME "..\bitmaps\alphabmp\trash.bmp" OF oWnd
oBmp:lTransparent := .T.

1. compiled with 18.1
2. compiled with 17.12

Code: Select all  Expand view  RUN

// Placing text on top of a bitmap

#include "FiveWin.ch"

#define TRANSPARENT 1

static oWnd

//----------------------------------------------------------------//

function Main()

   local oBmp

   DEFINE WINDOW oWnd TITLE "Text on a bitmap"

   @ 1, 1 BITMAP oBmp FILENAME "..\bitmaps\alphabmp\trash.bmp" OF oWnd

   oBmp:bPainted = { || SetBkMode( oBmp:hDC, TRANSPARENT ),;
                        TextOut( oBmp:hDC, 5, 5, "Hello" ) }

   ACTIVATE WINDOW oWnd

return nil
 

regards
Uwe

[nageswaragunupudi]

Mr Uwe

I think you did not see my posting above.
If you apply the fix I posted above to bitmap.prg, then it behaves like 17.12.

[ukoenig]

Yes
I didn*t notice that You added a fix in the meantime sorry

regards
Uwe

[nageswaragunupudi]

Thank you very much for testing and reporting.
Hope you will do more tests.